Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): remove loop.chan #4348

Merged
merged 2 commits into from
Nov 15, 2024
Merged

chore(core): remove loop.chan #4348

merged 2 commits into from
Nov 15, 2024
+6 −108

Conversation

M1nd3r
Copy link
Contributor

@M1nd3r M1nd3r commented Nov 14, 2024 •
edited
Loading

All usage of loop.chan in the THP branch was replaced by the new loop.mailbox (introduced here: 9f01c9f). The loop.chan is no longer used in the main branch thanks to the RustLayout rework, Global layout object PR.

If there are no objections, the loop.chan can be removed from the codebase.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@obrusvit
Copy link
Contributor

The description of loop.chan from docs/core/src/event-loop.md could also be removed.

Ideally, we'd like a short documentation for loop.mailbox. Not necessarily in this PR.

@M1nd3r
Copy link
Contributor Author

M1nd3r commented Nov 14, 2024

The description of loop.chan from docs/core/src/event-loop.md could also be removed.

Ideally, we'd like a short documentation for loop.mailbox. Not necessarily in this PR.

The description of loop.chan was removed and a (short) description of loop.mailbox added here 3ccc462

@M1nd3r M1nd3r marked this pull request as ready for review November 14, 2024 10:16
@M1nd3r M1nd3r merged commit f5100cd into main Nov 15, 2024
94 checks passed
@M1nd3r M1nd3r deleted the M1nd3r/remove-chan branch November 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Firmware
Status: 🤝 Needs QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M1nd3r @obrusvit @mmilata